Re: [Libreoffice] [PATCH] Make find-german-comments exit when given soon-to-be-removed dirs

Miklos Vajna <vmiklos -AT- frugalware.org>
Sat, 3 Dec 2011 02:11:54 +0100

On Fri, Dec 02, 2011 at 11:59:41PM +0100, Philipp Weissenbacher <p.weissenbacher@gmail.com> wrote:

This patch make f-g-c spit out an error message and quit when trying
to execute it in core/automation or core/basic/source/app.

I admit that it might not be that most pythonic way of doing things
(I'm still new to the language).


Nah, but in fact now you let it exit in any directory. :)

~/git/libreoffice/master/writerfilter$ ../bin/find-german-comments 
These directories will soon be removed!
Do not bother translating comments here. Exiting now.

Did you test that case?

(Also the new glob import seems to be unused.)

Thanks.

Attachment: pgpavVgqFtmco.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH] Make find-german-comments exit when given soon-to-be-removed dirs · Philipp Weissenbacher
- Re: [Libreoffice] [PATCH] Make find-german-comments exit when given soon-to-be-removed dirs · Miklos Vajna
- [Libreoffice] [RESOLVED][PATCH] Make find-german-comments exit when given soon-to-be-removed dirs · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.