Re: [Libreoffice] [PATCH][PUSHED] memory leaks found with valgrind

On Thu, Nov 17, 2011 at 09:12:49PM -0500, August Sodora wrote:
> I always forget [PATCH]
>
> August Sodora
> augsod@gmail.com
> (201) 280-8138
>
>
>
> On Thu, Nov 17, 2011 at 9:12 PM, August Sodora <augsod@gmail.com> wrote:
> > Hello,
> >
> > I was a little curious about valgrind so I ran it against soffice and
> > found a few memory leaks. The two that I looked at are very minor but
> > I figured I'd try them to start with. The attached patch corrects the
> > first and the second I had difficulty understanding.
> >
> > The first is caused by not calling XFreeGC when the splash screen closes:
> >
> > ==11027== 160 bytes in 1 blocks are definitely lost in loss record 7 of 8
> > ==11027==    at 0x4A06031: malloc (vg_replace_malloc.c:236)
> > ==11027==    by 0x3FA0A215EB: XCreateGC (CrGC.c:75)
> > ==11027==    by 0x406480: splash_create_window (splashx.c:555)
> > ==11027==    by 0x406E44: splash_create (splashx.c:781)
> > ==11027==    by 0x4088D3: sal_main_with_args (start.c:850)
> > ==11027==    by 0x408755: main (start.c:789)

Lionel pushed that. Thanks!

D.