Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

On Tue, 2011-11-29 at 19:39 +0100, Pierre-André Jacquod wrote:
> Hello,
> sorry, I was sure there was more about it...but too early this morning, 
> I could not sort out all points.
>
> > Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to
> > not include newly appended columns of an area. Why?
> by the way, this reflect the comment in
>
> void ScDBData::ExtendDataArea(ScDocument* pDoc)
> {
>      // Extend the DB area to include data rows immediately below.
>
> which comment is from Kohei ( 9f9ff37f ) who toke this from a previous 
> comment. Hence, the change would make the call be in line with the comment.
>
> This is the original reason why I started to play with it and changed it 
> like this, since comment and implementation were not coherent.

So, it's possible that there is some kind of code merging madness going
on here.

To give you a background, this "extend range downward" functionality was
present for quite some time in Go-OO, which was never merged into the
official OOo.  Naturally, when we did the LibreOffice, that
functionality was merged in.

During the 3.3 release period, we were constantly merging changes from
OOo almost on every milestone release (IIRC).  And I noticed that OOo
added similar "extend range downward" functionality during that period
but quite in late milestone, but did it differently than the way we did
it.

We ended up merging that change anyway, and because we both did it
differently, the merge may have ended up making the code around here
funny.  That would explain some of the inconsistencies you may be seeing
in this neighborhood.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc