Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


hello,
here attached an new patch (hopefully wiser) to solve the mentioned bug. This ensure that the call to ExtendDataArea does as commented in the code sc/source/core/tool/dbdata.cxx :
// Extend the DB area to include data rows immediately below.
and does not shrink the original area... So having a smaller area after the function is clearly wrong.

If you agree, I will push it to master.

BUT this is a workaround, to compensate the not so correct behaviour of GetDataArea :-(

I did this patch in order to bring the correction in time for 3.5.0 & 3.4.5, but I agree, that this is suppressing a symptom and not the root cause.

About the root cause: I am still studing the code of the both mentioned functions and their integration with filters and filtered areas. Before touching it, I would like to define what should be the desired effect. Further some tests have shown me that the behaviour (regarding area) is not the same, depending if the filter is activated with Data->Filter->AutoFilter or Standard filter. I fear some parts will need to be quite overhauled.

As said, won't be ready for 3.5, so first this short term solution.

Thanks toa all for having helped me so far.
Best regards
Pierre-André

Attachment: 0001-fdo-42286-do-not-shrink-the-filtered-area-when-calli.patch
Description: application/mbox


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.