Re: [Libreoffice] I need some advice to fix fdo#40363

Hi Jean-Baptiste,

On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote:

> The bug described in fdo#40363 may occur if you make a typo when type
> some dates in Calc.

Thanks for investigating, I'll dig into that.

> If I modify Date::IsValid so that only dates strictly between 1582-10-05
> and 1582-10-15 are not valid, then the chart wizard works without problem.

Interesting.. but probably similar problems arise when the date would go
negative. Or earlier..

> I do not understand why every dates before 1582-10-15 should not be
> valid when only dates from 1582-10-05 to 1582-10-14 do not exist due to
> the switch from julian calendar to gregorian calendar.

Well, the Date class was never declared to work with dates earlier than
when the Gregorian calendar sprang into existence ;-)

> Now, my question is what to do? Is it a good idea to modify
> Date::IsValid in tdate.cxx without knowing why it works in LibO 3.3 ?

I don't think so. More promising probably would be to switch to a real
calendar.. I may take a stab at that.  But first investigate how Chart
and Calc interface there.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgp5A93UdKuv_.pgp
Description: PGP signature