Hi Michael, Stephan, all,
On Tue, Nov 22, 2011 at 12:46:52PM +0100, Michael Stahl wrote:
one requirement i would have on conditional compilation is that, whether
--disable-dbgutil or --enable-dbgutil, objects built with debug=t
(resulting in OSL_DEBUG_LEVEL being set to non-zero) should always be
binary compatible with objects built without debug=t.
this makes e.g. tracking down bugs introduced by mis-optimisation much
easier; i think we are in agreement on this point.
Full agreement here.
i think i've seen members of SwDoc being added with:
#if OSL_DEBUG_LEVEL > 1
#if OSL_DEBUG_LEVEL > 0
this kind of thing always struck me as wrong: it should be DBG_UTIL,
will try to clean that up a bit...
A bit of digging in gits history shows that to be a blunt removal commit of
DBG_UTIL in sw in 2010. I cant make any sense of it, as it completly broke non
DBG_UTIL debug builds for no gain. Can anyone enlighten me on this?
hmmm... i wonder if it makes sense to not distinguish between warnings
and info at compile-time (given that it is only active on debug builds
anyway), so it is not required to recompile a module to get full debug
output...
Agree. The only valid reason for not having all debug tools compiled in is
runtime performance and binary size. Once you are debugging those are mostly
irrelevant.
in summary, sounds like a good plan :)
yep.
Best,
Bjoern
Context
- Re: [Libreoffice] Assertions and Logging (continued)
Re: [Libreoffice] Assertions and Logging · Stephan Bergmann
Re: [Libreoffice] Assertions and Logging · Bjoern Michaelsen
Re: [Libreoffice] Assertions and Logging · Michael Stahl
- Re: [Libreoffice] Assertions and Logging · Bjoern Michaelsen
Re: [Libreoffice] Assertions and Logging · Lubos Lunak
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.