Re: [Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

> > I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used
> > but never mentioned.
>
> not sure what you mean by "used but never mentioned" where is it used ?

I tried removing SV_ICON_ID_HTML_DOCUMENT because I also did not see
it during my grepping. However I would get some errors during make
dev-install about the missing icons (I don't have the error with me
sorry).

> opengrok at least doesn't show it being used just beyond the 'Bitmap'
> definitions in images.src and the define itself. Can you elaborate?
> >  I fell into the same pitfall while removing the
> > images. The patch AS-IS was compiling on linux AFAICT.
>
> not from clean ( on linux )

Fair enough, I will try with clean builds for the next round.

> I have restarted my build from clean, assuming the build completes without
> errors, unless I get some sort of "stop the world will end" I will commit
> the patches again.

Don't try it too hard. It shouldn't have broken anything. If it does,
it means I should have done more research and testing on my side!

Thanks,
Julien