Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Caolán,

Thank you for your comments.
Here is the patch.

Cheers,

On Wed, Nov 9, 2011 at 12:01 AM, Caolán McNamara <caolanm@redhat.com> wrote:

On Tue, 2011-11-08 at 22:43 +0900, Daisuke Nishino wrote:
Hi all,

I removed some uses of SvStringsSortDtor, which is listed in
http://wiki.documentfoundation.org/Easy_Hacks#Easy_Hacks

Looks good (Initially I thought there was a few vectors with potential
dups in them before I scrolled down a bit to see the sort, unique,
erase :-)). So pushed, thanks for these.

Looking at htmlexp.cxx:1320, pSrcArr is used to lookup for an index of
a string, and then the index is applied to pDstArr.
In my understanding indices of two arrays are unrelated, because
arrays are sorted by their respective contents.

Yeah, it's puzzling. Original code doesn't look right at all.

I guess what is intended here is mapping of strings, from pSrcArr to
pDstArr (with incorrect implementation).

The intent seems fairly clear anyway, so it looks like a std::map
identifier->filename is what's wanted.

C.




-- 
Daisuke Nishino

Attachment: 0001-Removed-SvStringsSortDtor.core.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.