Re: [Libreoffice] [PUSHED] First Patch

Second patch.

Please Caolán, can you update and add file&line number information on
unusedcode.easy

I cannot find same class definition listed on unusedcode.easy

Best Regards


2011/11/3 Emanuele Fia <emanuele.fia@gmail.com>:
> > git reset -hard HEAD~1 # warning this looses the head commit
> > before running ./g pull -r to avoid conflicts (assuming you didn't do
> > any more commits yet).
>
> This is for reset my local repo and restore the current version on git
> repository ?
>
>
> > A thing that really helps us, is if you could send a mail to the list
> > with a blanket license for your commits: of the form you can see linked
> > into the developers wiki here:
>
> Ok , where i can find infromation about  MPL/LGPLv3+ ?
>
> (Sorry this is my first experience as developers)
>
>
> > Anyhow ! the CurrencyBox stuff seems like it might be a good place to
> > investigate if you want to do a bigger chunk of cleanup here; are you
> > able to compile after changing things ?
>
> I'm not sure i understand correcty...
>
> (What's CurrencyBox ? )
>
> Yes , i'm able to compile code and check if build fails after changes or not.
>
> But how i can submit patch ? Send an email to this maillist and stop?
> My last patch is "formatted" correctly?
>
> Thanks
>
> 2011/11/3 Caolán McNamara <caolanm@redhat.com>:
> > On Thu, 2011-11-03 at 11:39 +0000, Michael Meeks wrote:
> > > On Wed, 2011-11-02 at 19:08 +0100, Emanuele Fia wrote:
> > > > I have to remove also form unusedcode.easy the function removed ?
> > >
> > >       I imagine so; although Caolan is really the expert here. I tweaked your
> > > patch a little, so as you may need to:
> >
> > Yeah, remove it from unusedcode.easy as well.
> >
> > I regenerate that list every now and then. But it's best to remove them
> > from the list manually when you remove the unused code so that noone
> > tries to remove an already removed method in the gap between
> > regenerations of the list.
> >
> > I really really should add file:line numbers to the tooling
> > (https://github.com/caolanm/callcatcher) I guess. Sometimes it can be
> > hard to find them because some of the unused methods are generated from
> > big macros.
> >
> > C.
From d05901ae00015e05c117de4c482befd7dd502445 Mon Sep 17 00:00:00 2001
From: Emanuele Fia <name29@name29-laptop.(none)>
Date: Thu, 3 Nov 2011 21:29:14 +0100
Subject: [PATCH] Removed unused code

---
 svx/source/inc/clonelist.hxx       |    1 -
 svx/source/svdraw/clonelist.cxx    |    5 ---
 unotools/source/i18n/charclass.cxx |   53 ------------------------------------
 3 files changed, 0 insertions(+), 59 deletions(-)

diff --git a/svx/source/inc/clonelist.hxx b/svx/source/inc/clonelist.hxx
index 3ed9156..d7ca903 100644
--- a/svx/source/inc/clonelist.hxx
+++ b/svx/source/inc/clonelist.hxx
@@ -46,7 +46,6 @@ class CloneList
 public:
 
     void AddPair(const SdrObject* pOriginal, SdrObject* pClone);
-    sal_uInt32 Count() const;
 
     const SdrObject* GetOriginal(sal_uInt32 nIndex) const;
     SdrObject* GetClone(sal_uInt32 nIndex) const;
diff --git a/svx/source/svdraw/clonelist.cxx b/svx/source/svdraw/clonelist.cxx
index 22474e5..fc7a594 100644
--- a/svx/source/svdraw/clonelist.cxx
+++ b/svx/source/svdraw/clonelist.cxx
@@ -68,11 +68,6 @@ void CloneList::AddPair(const SdrObject* pOriginal, SdrObject* pClone)
     }
 }
 
-sal_uInt32 CloneList::Count() const
-{
-    return maOriginalList.size();
-}
-
 const SdrObject* CloneList::GetOriginal(sal_uInt32 nIndex) const
 {
     return maOriginalList[nIndex];
diff --git a/unotools/source/i18n/charclass.cxx b/unotools/source/i18n/charclass.cxx
index 5fcd2ae..fad144d 100644
--- a/unotools/source/i18n/charclass.cxx
+++ b/unotools/source/i18n/charclass.cxx
@@ -116,21 +116,6 @@ sal_Bool CharClass::isAsciiAlpha( const String& rStr )
 }
 
 
-// static
-sal_Bool CharClass::isAsciiAlphaNumeric( const String& rStr )
-{
-    if ( !rStr.Len() )
-        return sal_False;
-    register const sal_Unicode* p = rStr.GetBuffer();
-    register const sal_Unicode* const pStop = p + rStr.Len();
-    do
-    {
-        if ( !isAsciiAlphaNumeric( *p ) )
-            return sal_False;
-    } while ( ++p < pStop );
-    return sal_True;
-}
-
 
 sal_Bool CharClass::isAlpha( const String& rStr, xub_StrLen nPos ) const
 {
@@ -154,22 +139,6 @@ sal_Bool CharClass::isAlpha( const String& rStr, xub_StrLen nPos ) const
 }
 
 
-sal_Bool CharClass::isAlpha( const String& rStr ) const
-{
-    try
-    {
-        if ( xCC.is() )
-            return isAlphaType( xCC->getStringType( rStr, 0, rStr.Len(), getLocale() ) );
-        else
-            return sal_False;
-    }
-    catch ( const Exception& )
-    {
-        DBG_ERRORFILE( "isAlpha: Exception caught!" );
-        return sal_False;
-    }
-}
-
 
 sal_Bool CharClass::isLetter( const String& rStr, xub_StrLen nPos ) const
 {
@@ -271,23 +240,6 @@ sal_Bool CharClass::isAlphaNumeric( const String& rStr, xub_StrLen nPos ) const
 }
 
 
-sal_Bool CharClass::isAlphaNumeric( const String& rStr ) const
-{
-    try
-    {
-        if ( xCC.is() )
-            return isAlphaNumericType( xCC->getStringType( rStr, 0, rStr.Len(), getLocale() ) );
-        else
-            return sal_False;
-    }
-    catch ( const Exception& )
-    {
-        DBG_ERRORFILE( "isAlphaNumeric: Exception caught!" );
-        return sal_False;
-    }
-}
-
-
 sal_Bool CharClass::isLetterNumeric( const String& rStr, xub_StrLen nPos ) const
 {
     sal_Unicode c = rStr.GetChar( nPos );
@@ -336,11 +288,6 @@ String CharClass::toUpper( const String& rStr, xub_StrLen nPos, xub_StrLen 
nCoun
     return toUpper_rtl(rStr, nPos, nCount);
 }
 
-void CharClass::toLower( rtl::OUString& rStr ) const
-{
-    rStr = toLower_rtl(rStr, 0, rStr.getLength());
-}
-
 String CharClass::toLower( const String& rStr, xub_StrLen nPos, xub_StrLen nCount ) const
 {
     return toLower_rtl(::rtl::OUString(rStr), nPos, nCount);
-- 
1.7.5.4