Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed

On Tue, 2011-10-25 at 10:23 +0200, Winfried Donkers wrote:
> I see that a solution is/was targeted for version 3.5. As of
> yesterday, that had not yet been achieved (the problem still persists
> with 3.5 and code from yesterday).
>
> The problem is quite annoying for users (such as in our company).
>
>  
>
> Does anyone know (Kohei Yoshida?) the current status of the work on
> this bug? 
>
> Is it something where I can be of help? (I used to develop in C++,
> before I had a stroke, nowadays the complexity must be low for me to
> work on it. Also, I will need assistence to get started. I can make
> LibO from source on an opensuse platform). 

So, Comment 8 in the bug should serve as a code pointer to start the
work.

https://bugs.freedesktop.org/show_bug.cgi?id=32826#c8

However, this one is a bit complex, as we would need to move the flags
that tell you which sheets are selected, from ScMarkData to ScDocument
(or most likely ScTable) in order for the mentioned code to access this
information during print preview.

There are lots of places where we query for the selected sheets, so this
transition will not be trivial, to say the least.

Having said that, it is still doable, with enough willingness to hack
and test.

I'd set the target for this bug to 3.5, but I have to admit, bug fixes
for 3.4.x has kept me busy for longer time than I expected, so I can't
guarantee that I get this fixed in time for 3.5.0 release.  Currently I
have 17 bugs with target 3.5.  Right now, there are still several
features I'd like to squeeze into 3.5.  So my plan is to squeeze those
features in first, then start fixing 3.5-targeted bugs.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc