Re: [Libreoffice] comprehensive binfilter tests?

On 10/21/2011 02:38 PM, Caolán McNamara wrote:
> On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote:
> > In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x
> > crashes on all of them under Linux/Windows. I did not try master. 3.3
> > is OK.
>
> master crashes for me alright,
> http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=86db50edeee1d556f993589da73140582789ef42
>  fixes it again for those docs anyway.
>
> caolanm->sberg: can you have a look at my fix, looks like merge bustage
> on merging in the fix for #i117310#, though that would indicate that
> whatever problem exists in 3.4.3 is different.

<http://hg.services.openoffice.org/cws/sb140/rev/85f71dba0516> 
(referenced from <https://issues.apache.org/ooo/show_bug.cgi?id=117310>) 
removes the

  if( !rPropSetInfo.is() )
    rPropSetInfo = rPropSet->getPropertySetInfo();

part only from 
binfilter/bf_xmloff/source/style/xmloff_SinglePropertySetInfoCache.cxx 
but not from the corresponding 
xmloff/source/style/SinglePropertySetInfoCache.cxx.  I guess it was a 
mistake I introduced when manually copying over the changes I made to 
the latter to the former, and it simply went unnoticed until now.

-Stephan