Re: [Libreoffice] Questions about push access

Hi Ivan, Michael,

On 2011-10-06 at 20:08 +0100, Michael Meeks wrote:

> > 1. I've performed my first push today and received this message:
>
>       Heh ;-) we get to add each committer to the commiters list manually -
> that is something I ought to do I guess, but Thorsten tends to do idly
> when the bounces happen.

Based on this, I've changed the rule there so that any new committer
should be allowed to post without need of further tweaking of the
settings.

> > 2. What changes should I avoid in my commits? I mean, what changes are
> > unwanted, needless, etc.
>
>       Clearly running indent gratuitously on the code, while it may improve
> it, makes the diff very hard to read ;-) beyond that - code cleanup,
> porting, easy hacks - anything non-controversial should go straight into
> master. Anything you're not sure - just ask on the list :-)
>
>       If you're hacking a module substantially, it makes sense to dung out
> un-necessary cruft, vertical line wasteage, over-verbose comments that
> reduce readability are all fair game I think.

Also, don't be shy to push for other people that send patches to the
mailing list! :-)  It is trivial - when you see a patch on the mailing
list that is correct, and you think it should go in, just save it (eg.
as the_patch.patch), and do:

# apply the patch (it applies including setting the right committer name
# and the commit message)
git am the_patch.patch
# check that everything applied well
git log -p
# check that it builds / does the work
# and finally
git push
# then send a reply to the mailing list that you pushed the patch; add
# [PUSHED] to the subject of the mail

And that's it :-)  You need to do more when the patch sent to the
mailing list is not produced using 'git format-patch' - in that case you
have to set the committer name using --author switch of the git commit
command.

All the best,
Kendy