Re: [Libreoffice] [PATCH] gbuild conversions

On 18.09.2011 23:07, Peter Foley wrote:
> I've attached two gbuild conversions. I'd appreciate it if someone could 
> check if I've missed anything before I commit these.

hi Peter,

looking pretty good, just a bit of nitpicking below :)

> One question, there are 2 tests in bean/test and 
> bean/test/applet/oooapplet that weren't run by the old build system. I 
> wasn't sure what to do with these so I just left them as-is.
> If I should do something else just let me know.

hmmm, there are quite a few such tests; if they weren't run in the old
build system then they most likely don't run and in many cases don't
build.  finding out whether any of these are salvageable and can be turned
into something useful is a task best done separately from gbuild conversion.

> Peter

> +ifeq ($(OS),LINUX)
> +$(eval $(call gb_Library_add_libs,officebean,\
> +     -lstdc++ \
> +))
> +endif
> +

this is probably unnecessary; the makefile.mk apparently disabled linking
against STLport, but LO got rid of STLport in the meantime and so we get
libstdc++ automatically just by using g++ as linker.

> -ob   bean    :       javaunohelper jurt ridljar unoil offapi udkapi NULL
[...]
> +ob   bean    :       NULL

please don't remove the dependencies, that makes it impossible to build
just this module from scratch (in the unlikely case that anybody would
want to do that...).

> -ea      eventattacher   :       offapi cppuhelper LIBXSLT:libxslt NULL
[...]
> +ea      eventattacher   :       NULL

same here.