Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code

Pierre-André Jacquod <pjacquod -AT- alumni.ethz.ch>
Tue, 13 Sep 2011 19:52:23 +0200

Hello,

That should happen in a DdeInstData ctor instead.


I intended to do something easier:
struct DdeInstData
{
    short x;

    DdeInstData(); // and of course implementing this
}


I've moved it into the ctor now.

Thanks, I was not able to react very quickly, making this during freetime ... and on Linux. Sorry.


Just for my education [answer is optional]:

The fact to change to class and use boost::noncopyable is an improvementnot related to this point I guess, since before the copy-ctor and copyassignment would have worked with the struct.


Or did I missed something?

Thanks.

regards
Pierre-André

Context

[Libreoffice] [patch] memset used on struc with std::vector / Windows code · Pierre-André Jacquod
- Re: [Libreoffice] [patch] memset used on struc with std::vector / Windows code · Eike Rathke
  - [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Caolán McNamara
    - Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Pierre-André Jacquod
      - Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.