Re: [Libreoffice] [patch] memset used on struc with std::vector / Windows code

Eike Rathke <ooo -AT- erack.de>
Sun, 11 Sep 2011 15:48:12 +0200

Hi Pierre-André,

On Sunday, 2011-09-11 14:20:57 +0200, Pierre-André Jacquod wrote:

the struct DdeInstData contains a std::vector, but was initialized
with memset( pData,0,sizeof(DdeInstData) )


Good catch.

So I tried to have a consistent initialization with the new struct layout.


That should happen in a DdeInstData ctor instead. Note that you don't
need to explicitly clear the vector on that newly allocated object, it
is created empty anyway.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] [patch] memset used on struc with std::vector / Windows code · Pierre-André Jacquod
- Re: [Libreoffice] [patch] memset used on struc with std::vector / Windows code · Eike Rathke
  - [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Caolán McNamara
    - Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Pierre-André Jacquod
      - Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.