Re: [Libreoffice] [PATCH] convert MathMLDTD to gbuild and add to tail_build

On 12.09.2011 23:26, Peter Foley wrote:
> gbuild conversion.
>
> Peter

hi Peter,

mostly looking good except:

> --- a/Module_tail_build.mk
> +++ b/Module_tail_build.mk
> @@ -35,6 +35,7 @@ $(eval $(call gb_Module_add_moduledirs,tail_end,\
>      formula \
>      hwpfilter \
>      lotuswordpro \
> +    MathMLDTD

missing backslash at EOL

>      Mesa \
>      oox \
>      padmin \
> diff --git a/RepositoryModule_ooo.mk b/RepositoryModule_ooo.mk
> index 3f09ba7..64093db 100644
> --- a/RepositoryModule_ooo.mk
> +++ b/RepositoryModule_ooo.mk
> @@ -53,6 +53,7 @@ $(eval $(call gb_Module_add_moduledirs,ooo,\
>      idl \
>      linguistic \
>      lotuswordpro \
> +    MathMLDTD

same problem

>      Mesa \
>      o3tl \
>      offapi \


> --- a/MathMLDTD/prj/build.lst
> +++ b/MathMLDTD/prj/build.lst
> @@ -1,3 +1,2 @@
> -md   MathMLDTD       :       solenv NULL
> -md   MathMLDTD                                                       usr1    -       all     
> md_mkout NULL
> -md   MathMLDTD\prj                                           get             -       all     
> md_prj NULL
> +md   MathMLDTD       : NULL

you remove the dependency on solenv; it seems that currently we don't
have any module (except solenv of course, and "testautomation" which
doesn't do anything) that does not directly or indirectly depend on
solenv; i wonder why that is?  is there perhaps some reason that modules
must depend on solenv?

regards,
 michael

-- 
"Do you not know, my son, with how little wisdom the world is governed?"
 -- Axel Oxenstierna