On 09/08/2011 01:44 AM, Eike Rathke wrote:
Hi Korrawit,
On Wednesday, 2011-09-07 22:01:09 +0700, Korrawit Pruegsanusak wrote:
Attached patch will clear the cppcheck warning for duplicate
expression on both sides of '<'.
Yup, good catch!
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a58ed493e572fef2c503bd329e924bb062ba9c96
Thanks
Eike
Korrawit, Eike, did you check the context to verify that it should
really read
a.nChar1 == a.nChar2
instead of
a.nChar1 == b.nChar1
in the second term of
(a.nChar1 < b.nChar1) || ((a.nChar1 == a.nChar2) && (a.nChar2 < b.nChar2))
? Somehow, that expression still looks suspicious. (At least, it does
not implement a lexicographical less-than relation. Not sure whether it
should or not, however.)
-Stephan
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.