Re: [Libreoffice] [REVIEW] undo/redo inserting cells in merged cells with shadows result in strange behavior

Eike Rathke <ooo -AT- erack.de>
Wed, 7 Sep 2011 16:46:44 +0200

Hi Markus,

On Tuesday, 2011-09-06 21:47:16 +0200, Markus Mohrhard wrote:

this patch removes some code that resulted in strange behavior with merged
areas and shadows.


That doesn't look right. ExtendMerge() includes a row/column that is
affected by the merged area's shadow and needs to be repainted after
redo.

The code extended the merged area by one column/row which
resulted in strange behavior with undo/redo.


And the strange behavior is?

It seems that the code was an
old hack for the ui part that is no longer needed.


I doubt that. Or what did change in that area?

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] [REVIEW] undo/redo inserting cells in merged cells with shadows result in strange behavior · Markus Mohrhard
- Re: [Libreoffice] [REVIEW] undo/redo inserting cells in merged cells with shadows result in strange behavior · Eike Rathke
- Re: [Libreoffice] [PUSHED] undo/redo inserting cells in merged cells with shadows result in strange behavior · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.