Re: [Libreoffice] [PATCH] build system patches

On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley <pefoley2@verizon.net> wrote:
> Hi,
>
> Here are some patches for various problems I encountered while building
> libreoffice.

0002...

From 913ba23fd2552436c7c48e83fd1d6ec7de6c2e96 Mon Sep 17 00:00:00 2001
> From: Peter Foley <pefoley2@verizon.net>
> Date: Mon, 5 Sep 2011 21:39:22 -0400
> Subject: [PATCH 2/7] /usr/local/lib
>
> If /usr/local/lib doesn't exist the Mozilla build fails.
> This patch fixes the build failure.

Is that an observed behavior or a speculated one ?

I mean:
1/ why on earth would our build ever try to create or even install
something in /usr/loca/bin when building an external lib. if we do,
then the fix is to stop that madness, not encourage it :-)
2/ if /usr/local/bin does not exist mkdir -p is not going to succeed
anymore than $(MKDIR), unless you run make as root or have g+w or o+w
authorization on /usr, both of which are a really, really bad idea.

Norbert

---
 moz/seamonkey-source-1.1.14.patch |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/moz/seamonkey-source-1.1.14.patch
b/moz/seamonkey-source-1.1.14.patch
index db62e8b..07d8500 100644
--- a/moz/seamonkey-source-1.1.14.patch
+++ b/moz/seamonkey-source-1.1.14.patch
@@ -6352,3 +6352,14 @@
 +PROCESS_MAP_FILE = grep -v ';-' $< | \
 +        sed -e 's,;+,,' -e 's; DATA ;;' -e 's,;;,,' -e 's,;.*,;,' > $@
 +
+--- misc/mozilla/directory/c-sdk/ldap/libraries/liblber/Makefile.in    2011-09-05
19:36:54.506893237 -0400
++++ misc/build/mozilla/directory/c-sdk/ldap/libraries/liblber/Makefile.in      2011-09-05
19:37:12.267893237 -0400
+@@ -82,7 +82,7 @@
+ export::    $(OBJDEST) $(LIBDIR) $(OBJS) $(LIBLBER)
+
+ $(LIBDIR):
+-      $(MKDIR) $(LIBDIR)
++      mkdir -p $(LIBDIR)
+
+ $(LIBLBER): $(OBJS) $(LIBDIR)
+       @echo ======= making $(LIBLBER)
-- 
1.7.6.1



> Thanks,
>
> Peter
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice