Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


At least with recent git trunk builds, make subsequentcheck fails in sw with

1) checkCrossReferences(complex.writer.CheckCrossReferences)
org.junit.ComparisonFailure: set reference field format doesn't result in correct field result expected:< 
1[.]> but was:< 1[]>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at complex.writer.CheckCrossReferences.checkField(CheckCrossReferences.java:120)
        at complex.writer.CheckCrossReferences.checkCrossReferences(CheckCrossReferences.java:176)

This appears to be caused by the fix for <https://bugs.freedesktop.org/show_bug.cgi?id=33960> "cross reference to a list number, dot bug," which removes the trailing "." from SwNumRule::MakeRefNumString.

The question is, is the below patch (which makes that subsequentcheck failure go away) right in adapting the failing test to the new code, or does this failure actually uncover unwanted side effects of the new code (I'm esp. unsure about changing "A. 1." to "A 1")?

diff --git a/sw/qa/complex/writer/CheckCrossReferences.java 
b/sw/qa/complex/writer/CheckCrossReferences.j
index cc7fcb1..597a14f 100644
--- a/sw/qa/complex/writer/CheckCrossReferences.java
+++ b/sw/qa/complex/writer/CheckCrossReferences.java
@@ -145,9 +145,9 @@ public class CheckCrossReferences {
             final String FldResult1 = "*i*";
             final String FldResult2 = "+b+*i*";
             final String FldResult3 = "-1-+b+*i*";
-            final String FldResult4 = "1.";
-            final String FldResult5 = " 1.";
-            final String FldResult6 = "A. 1.";
+            final String FldResult4 = "1";
+            final String FldResult5 = " 1";
+            final String FldResult6 = "A 1";

             // variables for current field
             com.sun.star.text.XTextField xField = null;

-Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.