Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi all

tring to a add a new property to calc document, i had to append it to an
idl file (offapi/com/sun/star/sheet/SpreadsheetDocumentSettings.idl)

one can read for example

    /** specifies whether the automatic adjustment of the row height is
        enabled.

        @since OOo 3.0
     */
    [optional, property] boolean IsAdjustHeightEnabled;

i modified the @since, putting LO 3.5 and end with a build error,
complaining that

"Version information in @since tag has incorrect format.\n"
Correct version format: \"OOo <major>.<minor>[.<micro> if micro is not
0]\"."

this is in
http://opengrok.libreoffice.org/xref/core/autodoc/source/parser_i/idoc/docu_pe2.cxx
so my question is

do we care about that ? (ie. specifying LO in the @since)
i think we should to make things clear to api users

the second question is about solving that :

this comes from the test
http://opengrok.libreoffice.org/xref/core/autodoc/source/parser_i/idoc/docu_pe2.cxx#517

performed at
http://opengrok.libreoffice.org/xref/core/autodoc/source/parser_i/idoc/docu_pe2.cxx#616

so, what should i do to be the cleanest and keep consystency over time ?

- drop the test ?
- modify the String to also take care about "LO" and "LibreOffice" ?

I can propose a patch as soon as there is an agreement on the
modification to do

Thanks

Laurent



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.