Re: [Libreoffice] buglet in 1ec7b6a4 (?)

Stephan Bergmann <stephan.bergmann.secondary -AT- googlemail.com>
Mon, 29 Aug 2011 12:08:17 +0200

On Aug 28, 2011, at 8:59 PM, Norbert Thiebaud wrote:

2011/8/28 Eike Rathke <ooo@erack.de>:

Hi Matúš,

On Sunday, 2011-08-28 19:04:08 +0200, Matúš Kukan wrote:

On 22 August 2011 18:17, Tom Tromey <tromey@redhat.com> wrote:

Commit 1ec7b6a4 changed autogen.sh to create autogen.lastrun only if
some arguments were provided when invoking autogen.sh.

However, Makefile still has:

Makefile: autogen.lastrun configure.in ooo.lst.in set_soenv.in Makefile.in
       ./autogen.sh

This means that my build fails with:

$ make
make: *** No rule to make target `autogen.lastrun', needed by `Makefile'.  Stop.


So, what is proper solution for this ?


IMHO autogen.sh should create an empty autogen.lastrun if no arguments
were provided.


yep… pushed


<http://cgit.freedesktop.org/libreoffice/core/commit/autogen.sh?id=3ea37ac7005c64f378756a5dbc3fbfbc3bf8b053>
 does not fix this for the one-argument case, however, due to an error introduced in 
<http://cgit.freedesktop.org/libreoffice/core/commit/autogen.sh?id=c0b9fdfbbaa46e984dbe6ea9e7f5adc943b9f248>.
  Attached patch would fix that.

-Stephan

Attachment: 0001-autogen-with-single-argument.patch
Description: Binary data

Context

[Libreoffice] buglet in 1ec7b6a4 (?) · Tom Tromey
- Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Matúš Kukan
  - Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Eike Rathke
    - Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Norbert Thiebaud
      - Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Norbert Thiebaud
        
        Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Matúš Kukan
      - Re: [Libreoffice] buglet in 1ec7b6a4 (?) · Stephan Bergmann
        
        [Libreoffice] [PATCH] [PUSHED] (was: Re: buglet in 1ec7b6a4 (?)) · Kohei Yoshida
        
        Re: [Libreoffice] [PATCH] [PUSHED] (was: Re: buglet in 1ec7b6a4 (?)) · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.