Hi Markus,
On Sat, Aug 27, 2011 at 9:24 AM, Markus Mohrhard
<markus.mohrhard@googlemail.com> wrote:
It would be nice if someone could give it a quick review before I push it.
Looks good to me. The second hunk was a bit hard to grok, but I came
to the same conclusion as you did.
Especially the long if statement is a bit tricky but I think that only the
first line was needed.
Yup. I agree. Suffice it to say that that if statement is one of the
stinkiest I've seen in this code base.
Kohei
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.