Re: [Libreoffice] [PATCH] for Bug 32719

Hi Thorsten, Jan, and Co.

Sorry for the delay. Here is the revised patch that fixes the dimension
problem without all the rough scratch work/comments from last time.

I will look into Rainer's comment.

Jeffrey

On Thu, Aug 11, 2011 at 1:50 AM, Thorsten Behrens <
thb@documentfoundation.org> wrote:

> jeffrey chang wrote:
> > Here is the patch for EasyHack 32719. I have also discovered another bug
> > relating to Impress Templates, documented here:
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=39705
> Hi Jeffrey,
>
> thanks a lot for that patch - we've talked about this bug, glad to
> see you tackling this.
>
> I've applied it & played a bit with it - the behaviour is changed,
> but at least for the scenario Rainer describes in comment #3 in the
> bug, not fixed? Maybe I'm missing something, are there other changes
> I need?
>
> Cheers,
>
> -- Thorsten



-- 
--Jeffrey Chang

From 349f813ac3de560a42a3de0138cfed7eaf4162af Mon Sep 17 00:00:00 2001
From: Jeffrey Chang <jeffdchang@gmail.com>
Date: Wed, 17 Aug 2011 23:30:02 +0800
Subject: [PATCH] Fixed template dimension problem on Impress.

---
 sd/source/core/sdpage.cxx |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index 8af853f..8fc20d8 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -1070,8 +1070,8 @@ Rectangle SdPage::GetLayoutRect() const
         {
             aLayoutPos.X() += long( aLayoutSize.Width() * 0.05 );
             aLayoutPos.Y() += long( aLayoutSize.Height() * 0.234 );
-            aLayoutSize.Width() = long( aLayoutSize.Width() * 0.9 );
-            aLayoutSize.Height() = long( aLayoutSize.Height() * 0.66 );
+            aLayoutSize.Width() = long( aLayoutSize.Width() * 0.88 );
+            aLayoutSize.Height() = long( aLayoutSize.Height() * 0.58 );
             aLayoutRect.SetPos(aLayoutPos);
             aLayoutRect.SetSize(aLayoutSize);
         }
@@ -2416,11 +2416,6 @@ void SdPage::SetObjText(SdrTextObj* pObj, SdrOutliner* pOutliner, 
PresObjKind eO
                     aString += String::CreateFromAscii( RTL_CONSTASCII_STRINGPARAM( 
"\n\t\t\t\t\t\t\t" ));
                     aString += String ( SdResId( STR_PRESOBJ_MPOUTLLAYER7 ) );
 
-                    aString += String::CreateFromAscii( RTL_CONSTASCII_STRINGPARAM( 
"\n\t\t\t\t\t\t\t\t" ));
-                    aString += String ( SdResId( STR_PRESOBJ_MPOUTLLAYER8 ) );
-
-                    aString += String::CreateFromAscii( RTL_CONSTASCII_STRINGPARAM( 
"\n\t\t\t\t\t\t\t\t\t" ));
-                    aString += String ( SdResId( STR_PRESOBJ_MPOUTLLAYER9 ) );
                 }
             }
             break;
-- 
1.7.3.4