Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Scarabeus,

thanks for the patch. It looked fine and I pushed it into the
libreoffice-3-4 branch, see
http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=5ab68a360f717b40b672d38ff29497c6b3c4e114

Just some nitpicking. Please, mention [REVIEW] in mail subject when you
want to integrate patch into a stable branch. It helps to get
attention ;-)

Also you should not sign off fixes by yourself. The commit into the
stable branch should be signed off by another person ;-)

Finally, I was surprised by the long commit messsage. My git force me to
use max 80 characters on the first line. The second line must be empty.
More detailed description can be on the next lines.


Best Regards,
Petr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.