On 13/08/11 09:38, Julien Nabet wrote:
Hello,
cppcheck detects division by 0 in sw/source/ui/vba/vbarows.cxx, line 266
I discussed this with Norbert on IRC, here what we propose to add
before this line :
if ((nNewWidth <= 0) || (nWidth <= 0))
{
OSL_ASSERT(!((nNewWidth <= 0) || (nWidth <= 0)));
return;
}
might be better to just throw a RuntimeException here
Is this add ok ? (if yes, I can commit and push it on master).
sure, I would say go for it
Noel
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.