Re: [Libreoffice] [PATCH] fix xml2cmp build with svn gcc

> > > > > "Norbert" == Norbert Thiebaud <nthiebaud@gmail.com> writes:

Norbert> 1/ Are we sure that this behavior will be seen in a _released_ gcc ?
Norbert> (not a rhetorical question, I'm a bit weary of chasing gcc trunk that
Norbert> closely)

I believe so; or at least, this is definitely a bug in LibreOffice.
'checkSize' is inherited from a dependent base class, so it must be
qualified.  See, e.g.:

http://www.parashift.com/c++-faq-lite/templates.html#faq-35.19

Norbert> 2/ I am not well equipped to apply in-lined patch like that (I use
Norbert> gmail as main mailbox for this dev-list... so it is cut-and-paste with
Norbert> horror stories about line wrapping and all)
Norbert> could you use git format-patch to generate patches and attach them
Norbert> (git format-patch as the added benefit that I don't have to type
Norbert> --author="Your Name <you@email> -m "a nice commit message that _I_
Norbert> would have to come up with" but instead cat <your_git_formated_patch>
Norbert> | git am

I will do that in the future, thanks for the tip.

Tom