Re: [Libreoffice] [PATCH] fix xml2cmp build with svn gcc

On Wed, Aug 10, 2011 at 11:20 AM, Tom Tromey <tromey@redhat.com> wrote:
> I tried building LibreOffice with svn trunk gcc.
>
> It dies in xml2cmp with:
>
> Compiling: xml2cmp/source/xcd/xmlelem.cxx
> In file included from ./xmlelem.hxx:38:0,
>                 from 
> /home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:30:
> ./../support/list.hxx: In instantiation of 'void DynamicList<XY>::insert(unsigned int, XY* 
> const&) [with XY = XmlElement]':
> /home/tromey/Space/LibreOffice/bootstrap/clone/ure/xml2cmp/source/xcd/xmlelem.cxx:263:1:   
> required from here
> ./../support/list.hxx:229:5: error: 'checkSize' was not declared in this scope, and no 
> declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
> ./../support/list.hxx:229:5: note: declarations in dependent base 'List<XmlElement*>' are not 
> found by unqualified lookup
> ./../support/list.hxx:229:5: note: use 'this->checkSize' instead
> dmake:  Error code 1, while making '../../unxlngx6.pro/obj/xmlelem.obj'
>
>
> The appended patch fixes this problem by adding a 'this->' qualifier.

Two remarks

1/ Are we sure that this behavior will be seen in a _released_ gcc ?
(not a rhetorical question, I'm a bit weary of chasing gcc trunk that
closely)

2/ I am not well equipped to apply in-lined patch like that (I use
gmail as main mailbox for this dev-list... so it is cut-and-paste with
horror stories about line wrapping and all)
could you use git format-patch to generate patches and attach them
(git format-patch as the added benefit that I don't have to type
--author="Your Name <you@email> -m "a nice commit message that _I_
would have to come up with" but instead cat <your_git_formated_patch>
| git am

Norbert