Re: [Libreoffice] [PATCH] Bug 39561 (XHTML export filter)

Hi,

At 17:26 9-8-2011, Noel Power wrote:
> On 04/08/11 16:14, Christophe Strobbe wrote:
> > Hi,
> >
> > Attached is a patch for Bug 39561 "Use svg:title, not svg:desc for 
> > XHTML img alt attribute [accessibility]" 
> > <https://bugs.freedesktop.org/show_bug.cgi?id=39561>.
> >
> > I am new to Git and LibreOffice development and generated this 
> > patch with "git diff ..." (I couldn't figure out how to use format-patch).
> the patch looks fine, but I am not at all sure about which attribute 
> should be mapped into the 'alt' tag, to me the description seems 
> like a better fit ( a more verbose image replacement is better ? ),

svg:title should definitely be mapped to the alt attribute (based on 
my understanding of XHTML, ODF and SVG, and on 10 years of R&D in 
accessibility).
The user should be able to decide whether or not to get a long 
description after getting the "short" description. A long description 
is not required for every image.

> otoh it would seem that the html & xhtml filters should be 
> consistent. I've committed the patch to master in any case,
>
> thanks for the patch
>
> btw, can you confirm patch is LGPLv3+/MPL1.1,

I confirm that I make this patch available under LGPLv3+/MPL1.1.


By the way, I could not find the full process for fixing and closing 
bugs on <http://www.libreoffice.org/get-involved/developers/> or 
<http://wiki.documentfoundation.org/Development>. I missed:
* any mention of the need to confirm that you submit your patch under 
LGPLv3+/MPL1.1 (and that you can make a blanket statement like the 
one by Lionel Elie Mamane two days ago 
<http://lists.freedesktop.org/archives/libreoffice/2011-August/016134.html>;
* Who closes the reported bug and when (presumably only after it has 
been committed). (Ah, I just noticed Noel closed the bug.)
Who should I contact to update the Wikipage?

Best regards,

Christophe



--
Christophe Strobbe
K.U.Leuven - Dept. of Electrical Engineering - SCD
Research Group on Document Architectures
Kasteelpark Arenberg 10 bus 2442
B-3001 Leuven-Heverlee
BELGIUM
tel: +32 16 32 85 51
http://www.docarch.be/
Twitter: @RabelaisA11y
---
Open source for accessibility: results from the AEGIS project 
www.aegis-project.eu
---
Please don't invite me to Facebook, Quechup or other "social 
networks". You may have agreed to their "privacy policy", but I haven't.