Re: [Libreoffice] [PATCH] Bug 39561 (XHTML export filter)

Noel Power <nopower -AT- novell.com>
Tue, 09 Aug 2011 16:26:06 +0100

On 04/08/11 16:14, Christophe Strobbe wrote:

Hi,
Attached is a patch for Bug 39561 "Use svg:title, not svg:desc forXHTML img alt attribute [accessibility]"<https://bugs.freedesktop.org/show_bug.cgi?id=39561>.
I am new to Git and LibreOffice development and generated this patchwith "git diff ..." (I couldn't figure out how to use format-patch).

the patch looks fine, but I am not at all sure about which attributeshould be mapped into the 'alt' tag, to me the description seems like abetter fit ( a more verbose image replacement is better ? ), otoh itwould seem that the html & xhtml filters should be consistent. I'vecommitted the patch to master in any case,


thanks for the patch

btw, can you confirm patch is LGPLv3+/MPL1.1,

Noel

Context

[Libreoffice] [PATCH] Bug 39561 (XHTML export filter) · Christophe Strobbe
- Re: [Libreoffice] [PATCH] Bug 39561 (XHTML export filter) · Noel Power
  - Re: [Libreoffice] [PUSHED] Bug 39561 (XHTML export filter) · Noel Power
  - Re: [Libreoffice] [PATCH] Bug 39561 (XHTML export filter) · Christophe Strobbe
    - Re: [Libreoffice] [PATCH] Bug 39561 (XHTML export filter) · Korrawit Pruegsanusak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.