Re: [Libreoffice] ccache support

On Sun, Aug 7, 2011 at 6:55 PM, Christian Lohmaier
<lohmaier+libreoffice@googlemail.com> wrote:
> On Mon, Aug 8, 2011 at 1:21 AM, Norbert Thiebaud <nthiebaud@gmail.com> wrote:
> > I've pushed
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378ca38f59518b018fccca8f
>
> Note on the Mac-OSX case:
> The previous check was not to completely disable ccache, but only to
> check whether --ccache-skip can be used safely. Even with unsuitable
> versions (like unpatched 2.4 or 3.0) you could use ccache, it was just
> that objective-c(++) was not cached.

humm... I need to take a closer look... Is that what the USE_CCACHE was for ?

> > This try to automatically use ccache when present, unless CC= or CXX=
> > was specified by the user or --disable-ccache was passed to autogen
> > This also detect if CC or CXX is already an alias for ccache, in which
> > case ccache is not prefixed to CC and/or CXX
>
> The latter is not done for the Mac OSX case when gcc 4.0 is forced,
> or am I overlooking something?
if you 'forced' gcc 4.0 via CC= then no there is no automatic ccache
if 4.0 is 'forced' because you did not specify CC and the gcc
picked-up is too recent, then yes ccache is used if allowed:

+ if test "$_os" = "Darwin" -a "$with_macosx_sdk" = "10.4" -a
"$_gpp_majmin" -ge "401" ; then
+ if test -z "$save_CXX" -a -x "$GCC_HOME/bin/g++-4.0" ; then
+ if test -z "$CCACHE" ; then
+ export CXX="$GCC_HOME/bin/g++-4.0"
+ else
+ export CXX="$CCACHE $GCC_HOME/bin/g++-4.0"
+ fi


> I personally would prefer if the heading-comments would use "#" and
> not "dnl" - any reason why you're using dnl and thus remove any hints
> on the structure of the checks from the generated configure?

Just mimetic behavior... I have no preference either way....

Norbert