Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote:
Hello,

In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I 
noticed the use of va_start without va_end.
I read it could create undefined behaviour, so I propose this simple patch.

...
+        va_end(pArgs);
      }
  }

If it's ok, i can commit and push it on master.

The va_end is tucked away hidden inside InitializeRanges_Impl in
svl/source/items/nranges.cxx

This looks rather ugly, it would be nicer to get the va_start and va_end
closer together, e.g. move the va_end out of InitializeRanges_Impl and
put it close to the two va_starts

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.