Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Caolán,

On Friday, 2011-07-29 12:26:04 +0100, Caolán McNamara wrote:

I left
SID_CURSORBLKDOWN_SEL
SID_CURSORBLKUP_SEL
SID_CURSORBLKLEFT_SEL
SID_CURSORBLKRIGHT_SEL

untouched because repetitions makes no sense to them AFAIK

I see that the pre-existing ::ExecuteCursor doesn't make a distinction
for the Block selections, it just repeats them the same as non block. So
I adjusted your patch to include them as well to be consistent between
moving, and selecting. (hopefully I haven't cocked this up, Kohei, et.
al. can double check it for me I guess)

Should be fine. At least the called methods seem to evaluate the
arguments properly. Whether the user expected the resulting action might
be different, as it depends on the starting position (within a data
block or outside) and odd vs even repeat values.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgporwxJeOAbc.pgp
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.