Re: [Libreoffice] [REVIEW] bugfixes which break the string freeze for 3.4.3

On Tue, 2011-07-26 at 15:17 +0200, Andras Timar wrote:
> I'd like to add the bugfix for
> https://bugs.freedesktop.org/show_bug.cgi?id=32895
> Somebody some day marked it as critical.

        :-) So - I'm not a huge fan of the code. What does:

+ for( int i = 0; i < nCount; ++i )
+ {
+ if( rString == ResId::toString( (const ResId)SfxResId( (sal_uInt16)(nSourceResIds + i) ) ) )
+ {
+ return ResId::toString( (const ResId)SfxResId( (sal_uInt16)(nDestResIds + i) ) );
+ }
+ }

        do ? it looks a tad baroque to me. I also dislike seeing it cut/pasted
into impress as well.

        Can we get a cleaner reading patch, that re-uses that in impress ? :-)

        ATB,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot