Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Michael, Bjoern, all

On 25 July 2011 13:34, Michael Meeks <michael.meeks@novell.com> wrote:
Hi Bjoern,

       First - this is great work :-) thanks for pulling this all together.

I agree, thanks.

       Matus - have you backed your work up as git format-patch output before
trying to get git to re-sync them to master ? :-) And of course, I'm
looking forward to your seeing work there: what module are you working
on currently ?

Well, there are more. Is it bad idea to push more than one at the same time?
But nothing is ready now. Almost in every module is something I can't deal with.
Some questions: (maybe not all necessary, I will then try to learn and
decide more myself)

First: I can use templates from solenv/gbuild/templates? Asking mainly
because of license part of file.

Do we need for each module or even library FOO_DLLPUBLIC? Or I can
just use SAL_DLLPUBLIC_EXPORT.

What to do with libraries?
Can I break things on other platforms and somebody else will fix that?
or should I really try to not.
In basctl there was: IF WNT SHL1STDLIBS+= $(SHELLLIB)
(SHELLLIB=-lgdi32 -lshell32 -ladvapi32 -lcomdlg32)
So I should add all of them (but I don't think all are really used) or
just nothing and somebody will add the right one ?

Can I also change names of libraries?
-        Name = SPECIAL_NAME(animcore);
+       Name = LIBNAME(animcore);
And because of things like
-SHL1IMPLIB= i$(TARGET) I should add something to RepositoryFixes?
And RepositoryFixes has section about WNT which has two parts but
there are common things mentioned twice. Maybe we could reorganize
that.

Is postprocess/rebase/coffbase.txt used? Do I need to change also that?

What to do with unused files or whole directories? remove or igore or
ask each time?

I've seen somewhere .IF "$(L10N_framework)"=="". Is the same variable
present in gbuild?

Last important: In scaddins there were idl files processed:
http://opengrok.libreoffice.org/xref/calc/scaddins/source/analysis/makefile.mk#125
Is it possible to add them into offapi or somewhere?
But I was able to use generated hpp files just with adding:
    -I$(realpath $(WORKDIR)/UnoApiHeaders/offapi) \
gb_Library_add_api,analysis,offapi was not enough, not sure why and
how it works.

Finally: Is there any preferred log message we want to use?

Thanks,
Matus

PS: What is the right place for this kind of questions? (to know in
the future, hopefully not /dev/null, I can try to ask less)

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.