Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Norbert, *,

On Mon, Jul 25, 2011 at 4:44 AM, Norbert Thiebaud <nthiebaud@gmail.com> wrote:
On Sun, Jul 24, 2011 at 8:24 PM, Christian Lohmaier
<lohmaier+libreoffice@googlemail.com> wrote:
Hi Norbert, *,

[..]
If matching SDK is available, use that, otherwise use whatever
"oldest" SDK is available and hope for the availability-macro stuff
(and more importantly the linking) doesn't fail.
This would of course require some more modification to the compiler /
linker arguments to support that method.

Wait.. isn't that exactly what you were so adamantly against ? the
'silently break compatibility' by not using explicitly the 10.4 SDK ?

No, as of course the user must explicitly use that switch. And the
non-SDK way to compile against 10.4 doesn't exist yet.
If that proves to work, then I would be fine with that method as well.
But I'm sceptical about this, so I definitely prefer the SDK method.
The "use other SDK when target is not available" is a "future task" so
to say. And of course should not be the default unless somebody proves
it actually works.

The problem with that method is not using newer api, that should work
more or less reliably - the problem is to create working builds with
that method.

I was adjusting my thinking as follow:

1/ by default we require 10.4 sdk. if it is not there we fail autogen.
(that is --with-macosx-sdk=10.4 and
--with-macosx-deployment-target=10.4 by default)

Yes, but see above for the two switches.

2/ the builder can override and say use 10.x sdk
(--with-macosx-sdk=10.x). using MACOSX_DEPLOYMENT_TARGET=10.4 by
default
3/ the builder can over-ride MACOSX_DEPLOYMENT_TARGET using
--with-macosx-deployment-target=10.y (of course 10.y <= 10.x)

And I see no need for the two switches, why deliberately use a "newer"
SDK than necessary? Use the one closest to the target version.
But anyway - the case where the target version and target SDK doesn't
match is not supported yet. MAC_OS_X_VERSION_MAX_ALLOWED needs to be
set for example.

So what I was written about choosing the closest matching SDK is under
the presumption that this additional method is in place and working
(which it is not yet).

It is to show that I personally don't see the need for two switches,
that providing the target version is what matters.
Until the alternative way to produce compatible builds is in place,
configure should error out if no matching SDK is found.

ciao
Christian

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.