Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter

Kohei Yoshida <kyoshida -AT- novell.com>
Fri, 22 Jul 2011 21:20:33 -0400

On Fri, 2011-07-22 at 19:44 +0200, Markus Mohrhard wrote:

So finally pushed it to master. It's a safe change as it only changes
the upper limit to 1E10.(and yes the check for greater 1E10 is
intended instead of greater equal because excel behaves the same way)

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=514fa420a68076537adfc8d7344a20e8c0baa3f3

Review and sign-off appreciated.


Looks good. Pushed to 3-4 with my sign-off.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>

Context

[Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Markus Mohrhard
- Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Eike Rathke
  - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Markus Mohrhard
    - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Michael Meeks
    - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Eike Rathke
- Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Regina Henschel
  - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Markus Mohrhard
    - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Michael Meeks
      - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Markus Mohrhard
        
        Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Kohei Yoshida
    - Re: [Libreoffice] [REVIEW] fix for fdo#37218: tinv only takes values up to 10000 as second parameter · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.