Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Jan, Hi Jacek,

script approach sounds good. I've used them for conversion from DBG_ to OSL_ already. Should be absolutely no problem to dump DBG_{C,D}TOR with it.

If it's ok I'm doing this. Should be done in some 10 minutes + building. Just give me the cue to ;)

Thomas

On 07/21/2011 07:32 PM, Jan Holesovsky wrote:
Hi Jacek,

Jacek Wolszczak píše v So 11. 06. 2011 v 11:21 +0200:

The patches attached hereto make base debug.hxx free.
I removed a lot of DBG_CHKTHIS, DBG_CTOR and DBG_DTOR with NULL argument
and did some standard #ifdef DBG_UTIL to #if OSL_DEBUG_LEVEL>  0
conversion.

I'm especially interested in getting some feedback on removing functions like:
DBG_CTOR(ODBTableDecorator, NULL);
DBG_DTOR(ODBTableDecorator, NULL);

Terribly sorry for the late answer, your mail fell through the cracks
somehow :-(

So - I myself have never used this kind of debug, and I think, it is
much better to use valgrind to check for bugs that might be somehow
uncovered by these DBG_CTOR etc. checks (if I understood them
correctly).

Though, they seem to be used more widely than just in base; so my
preferred approach (if we want to get rid of these) would be to come up
with a script that will remove the DBG_CTOR / DBG_DTOR / ... over all
the codebase - how does that sound?

Thank you,
Kendy

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.