Re: [Libreoffice] [PATCH] Make base debug.hxx free

Hi Jan, Hi Jacek,

script approach sounds good. I've used them for conversion from DBG_ to 
OSL_ already. Should be absolutely no problem to dump DBG_{C,D}TOR with it.

If it's ok I'm doing this. Should be done in some 10 minutes + building. 
Just give me the cue to ;)

Thomas

On 07/21/2011 07:32 PM, Jan Holesovsky wrote:
> Hi Jacek,
>
> Jacek Wolszczak píše v So 11. 06. 2011 v 11:21 +0200:
>
> > The patches attached hereto make base debug.hxx free.
> > I removed a lot of DBG_CHKTHIS, DBG_CTOR and DBG_DTOR with NULL argument
> > and did some standard #ifdef DBG_UTIL to #if OSL_DEBUG_LEVEL>  0
> > conversion.
> >
> > I'm especially interested in getting some feedback on removing functions like:
> > DBG_CTOR(ODBTableDecorator, NULL);
> > DBG_DTOR(ODBTableDecorator, NULL);
>
> Terribly sorry for the late answer, your mail fell through the cracks
> somehow :-(
>
> So - I myself have never used this kind of debug, and I think, it is
> much better to use valgrind to check for bugs that might be somehow
> uncovered by these DBG_CTOR etc. checks (if I understood them
> correctly).
>
> Though, they seem to be used more widely than just in base; so my
> preferred approach (if we want to get rid of these) would be to come up
> with a script that will remove the DBG_CTOR / DBG_DTOR / ... over all
> the codebase - how does that sound?
>
> Thank you,
> Kendy
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice