Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

Hi Laurent,

On Fri, 2011-07-15 at 19:41 +0200, Laurent Godard wrote:
> Here is my first patch and want at first thanks a lot everybody who
> helped me starting my build and especially Kohei for his patience and
> deep knowledge in calc. Kohei is a great mentor :-)

        First - welcome ! :-) it's great to see your code.

> The result with the test case in the fdo#35357 is a drop for the 1211
> namedRanges from 5.781 seconds to 0.931 seconds.

        Sounds like a really useful speedup :-) calc is packed with fertile
ground for optimisations I think ...

> it would also be great for me if it could be part of the 3.4.x branch as
> this would affect a large number of my users instead of being stuck to
> OOo 3.2.1

        I don't see a problem with that; sounds like a nasty bug - but it'd be
targetted at 3.4.3 I suspect; wrt. the patch review Kohei or Markus
would be able to do that quickest, so it'll be another few hours until
they're around.

        Good stuff :-)

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot