Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

Hello Albert,

nice work but I have some comments.

Operator== should have return type bool and not int(I saw that ScDocOptions
used int too, but I have changed that already).
But all in all I think we shouldn't introduce operator== there.
I didn't like the old approach with operator== but after your changes it
seems even more unnecessary. Let's just use ScAppOptions directly and set
the keybinding even if it is the same keybinding as the old one. With this
approach you don't need to compare two ScAppOptions instances and there is
no need for operator== anymore. And all in all I think we can remove the two
dynamically created ScAppOption instances with this approach.

If you need some more information or advise, feel free to ask.

Regards,
Markus

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.