Re: [Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

Hi,
Made a minor fix to the patch.
/Albert

On Sat, Jun 25, 2011 at 23:44, Albert Thuswaldner
<albert.thuswaldner@gmail.com> wrote:
> Hi
> Submitting a patch for review. This one moves the misplaced
> Compatibility options from ScDocOptions to ScAppOptions. Please let me
> know if you want me to improve some parts of it.
>
> The rational behind this move, see:
> http://lists.freedesktop.org/archives/libreoffice/2011-May/013087.html
>
> See also:
> http://lists.freedesktop.org/archives/libreoffice/2011-June/thread.html#14140
>
> Once you are happy with it you can commit the patch under the terms of
> MPL 1.1 / GPLv3+ / LGPLv3+ triple license.
>
> Then I will do the same for the formula options.
>
> /Albert
From a8b36aa5f9e8c7b7d66e4b800545fba2ffa4e97b Mon Sep 17 00:00:00 2001
From: Albert Thuswaldner <albert.thuswaldner@gmail.com>
Date: Tue, 28 Jun 2011 23:45:03 +0200
Subject: [PATCH 2/2] Minor fix on overloaded operator function

---
 sc/inc/appoptio.hxx |   38 +++++++++++++++++++-------------------
 1 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/sc/inc/appoptio.hxx b/sc/inc/appoptio.hxx
index b770013..2bab8f1 100644
--- a/sc/inc/appoptio.hxx
+++ b/sc/inc/appoptio.hxx
@@ -141,27 +141,27 @@ inline const ScAppOptions& ScAppOptions::operator=( const ScAppOptions& rCpy )
     return *this;
 }
 
-inline int ScAppOptions::operator==( const ScAppOptions& rCpy ) const
+inline int ScAppOptions::operator==( const ScAppOptions& rOpt ) const
 {
     return  {
-        rCpy.nTabCountInNewSpreadsheet   == nTabCountInNewSpreadsheet
-    &&  rCpy.eMetric                     == eMetric
-    &&  rCpy.eZoomType                   == eZoomType
-    &&  rCpy.bSynchronizeZoom            == bSynchronizeZoom
-    &&  rCpy.nZoom                       == nZoom
-    &&  rCpy.pLRUList                    == pLRUList
-    &&  rCpy.nStatusFunc                 == nStatusFunc
-    &&  rCpy.bAutoComplete               == bAutoComplete
-    &&  rCpy.bDetectiveAuto              == bDetectiveAuto
-    &&  rCpy.nTrackContentColor          == nTrackContentColor
-    &&  rCpy.nTrackInsertColor           == nTrackInsertColor
-    &&  rCpy.nTrackDeleteColor           == nTrackDeleteColor
-    &&  rCpy.nTrackMoveColor             == nTrackMoveColor
-    &&  rCpy.eLinkMode                   == eLinkMode
-    &&  rCpy.nDefaultObjectSizeWidth     == nDefaultObjectSizeWidth
-    &&  rCpy.nDefaultObjectSizeHeight    == nDefaultObjectSizeHeight
-    &&  rCpy.mbShowSharedDocumentWarning == mbShowSharedDocumentWarning
-    &&  rCpy.eKeyBindingType             == eKeyBindingType
+        rOpt.nTabCountInNewSpreadsheet   == nTabCountInNewSpreadsheet
+    &&  rOpt.eMetric                     == eMetric
+    &&  rOpt.eZoomType                   == eZoomType
+    &&  rOpt.bSynchronizeZoom            == bSynchronizeZoom
+    &&  rOpt.nZoom                       == nZoom
+    &&  rOpt.pLRUList                    == pLRUList
+    &&  rOpt.nStatusFunc                 == nStatusFunc
+    &&  rOpt.bAutoComplete               == bAutoComplete
+    &&  rOpt.bDetectiveAuto              == bDetectiveAuto
+    &&  rOpt.nTrackContentColor          == nTrackContentColor
+    &&  rOpt.nTrackInsertColor           == nTrackInsertColor
+    &&  rOpt.nTrackDeleteColor           == nTrackDeleteColor
+    &&  rOpt.nTrackMoveColor             == nTrackMoveColor
+    &&  rOpt.eLinkMode                   == eLinkMode
+    &&  rOpt.nDefaultObjectSizeWidth     == nDefaultObjectSizeWidth
+    &&  rOpt.nDefaultObjectSizeHeight    == nDefaultObjectSizeHeight
+    &&  rOpt.mbShowSharedDocumentWarning == mbShowSharedDocumentWarning
+    &&  rOpt.eKeyBindingType             == eKeyBindingType
     };
 }
 
-- 
1.7.3.4