Re: [Libreoffice] [REVIEW] Better support for distro packaging

Michael Meeks píše v Pá 08. 07. 2011 v 15:27 +0100:
> Hi Petr,
>
> On Fri, 2011-07-08 at 16:00 +0200, Petr Mladek wrote:
> > are you fine with adding the attached changes into master and
> > libreoffice-3-4 branch?
>
>       So - overall this looks good, particularly if it helps to kill the
> 'build' module finally and completely. Of course, if it came from build/
> perhaps it is not really new stuff anyway :-)

yes

>       Did you mean to change the normal 'make install' rule to use that @
> substitution ?

Yes, "make install" sources the profile "[Ee]nv.[Ss]et.sh" and it is
perfectly fine to use the new variable.

>       Finally - I'm not a huge fan of that mv_file_between_flists cruft -
> indeed, I did a bit of work to try to straighten some of that out for a
> few patterns: we should do that in the scp2 itself I think [ now that we
> can do that easily (surely?) ].

I do not like them as well. Sigh, there were many so many such calls. I
did not have power and time to double check it ;-)

Thanks for looking at it.


Best Regards,
Petr