Hi Petr, I've tested your patch with my test docs and for me it's OK.I've just noticed a small issue when inserting a chart in Calc : when switching out from edit mode, the top line of the graphic becomes blurred.
I attach a test file, so you can judge the issue. Have a nice day, RB Le 20/06/2011 17:35, Petr Mladek a écrit :
Hi Ronald, Roland Baudin píše v Pá 17. 06. 2011 v 23:23 +0200:Hi, here is a small patch for sw that fixes another issue related to bug 33781 that I already fixed last month. The problem is that a graphic object of type "Draw 8" is not anti-aliased when anchored as char (see test file for example). IMHO, this patch is safe and acts exactly the same as the previous fix for bug 33781.It works nice. Well, just after your new lines there is another hack with aliasing for http://openoffice.org/bugzilla/show_bug.cgi?id=99665 . It solves the problem where the aliasing caused problems => we should be more careful with setting aliasing to ANTIALIASING_ENABLE_B2DDRAW globally. I prefer the more conservative approach from i#99665. It modifies the current aliasing using "byte or" (operator |) and restores the original aliasing at the end of the "if" block. I see that the aliasing value is always modified by byte operators '&', '|'. Try to search for ANTIALIASING_ENABLE_B2DDRAW at http://opengrok.libreoffice.org/ So, what do you think about the attached patch? It uses the conservative approach from i#99665 also for your two changes. Also it combines your fix with the fix for i#99665 to avoid two nFormerAntialiasingAtOutput variables. I would prefer to sort this out before we cherry-pick it to libreoffice-3-4 branch. Best Regards, Petr
-- X File Explorer http://roland65.free.fr/xfe Toutes Choses http://roland65.free.fr/ttc
Attachment:
ex.ods
Description: application/vnd.oasis.opendocument.spreadsheet