Re: [Libreoffice] [REVIEW] patch for fdo#38455

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Tue, 21 Jun 2011 08:13:24 +0200

Hello,

after I talked to Michael on IRC we agreed that the following patch is much
better.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4defbffb7654402cf6bbd4b8c3cb0d897ce88126

It fixes an additional potential crash.

Regards,
Markus

2011/6/20 Michael Meeks <michael.meeks@novell.com>


On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote:

      The rest of that method seems to assume in several places that
pActiveViewSh can be NULL and checks for that:


        Markus is committing an updated patch to master, that I'd love to
see
on -3-4 and also in -3-4-1 it potentially fixes another as-yet-un-found
crasher too.

       Thanks,

               Michael.

--
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

Context

[Libreoffice] [REVIEW] patch for fdo#38455 · Markus Mohrhard
- Re: [Libreoffice] [REVIEW] patch for fdo#38455 · Michael Meeks
  - Re: [Libreoffice] [REVIEW] patch for fdo#38455 · Michael Meeks
    - Re: [Libreoffice] [REVIEW] patch for fdo#38455 · Markus Mohrhard
    - Re: [Libreoffice] [REVIEW] patch for fdo#38455 · Petr Mladek
      - Re: [Libreoffice] [REVIEWED][PUSHED: 3-4, 3-4-1] patch for fdo#38455 · Petr Mladek
      - Re: [Libreoffice] [REVIEW] patch for fdo#38455 · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.