Hi,
Kohei Yoshida píše v Út 14. 06. 2011 v 14:06 -0400:
I would like to cherry-pick the following commit on master
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=478533a86b29341e00128fb6eda8237dfb9cf3cf
to the -3-4 branch (and -3-4-1 if it makes sense). There is no bug
report associated with this (yet), but this accidentally changes the
behavior of ScMatrix pre- and post-refactoring. When GetString() is
called on an empty element, the old code would return an empty string,
but the new code sets an error instead. I made this change, and this
change was unintentional. GetString() should still return an empty
string when called on an empty element.
Review & sign-off appreciated.
Looks good to me, and behaving according to the explanation :-) - pushed
to libreoffice-3-4. Two more reviews to get it to -3-4-1 needed.
Thank you,
Kendy
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.