Re: [Libreoffice] [PATCH] [MAC/WINDOWS] Simplified #define OSL_FILE_TRACE

Hi,

any Mac or Windows opinions?

Christina

Am 16.05.2011 16:54, schrieb Michael Meeks:
> Hi Christina,
>
> On Fri, 2011-05-13 at 21:40 +0200, Chr. Rossmanith wrote:
> > if I remember correctly cppcheck complained about some statements in the
> > context of OSL_FILE_TRACE. This patch simplifies the definition of
> > OSL_FILE_TRACE ( =>   code better readable) and facilitates compiling
> > without warnings.
>         :-) I imagine the original is down to compilers not having sane var-arg
> macro support.
>
>         Whether we can rely on that working everywhere nowadays is an
> interesting question ;-) I guess a Mac / Windows opinion is worth
> getting. If we can - then osl/diagnose.h should be fixed up too.
>
>         ATB,
>
>                 Michael.