Hi Christina,
Chr. Rossmanith wrote (31-05-11 14:03)
more duplicate code cleanup.
Good to see your work :-)
Class SfxObjectShell has two nearly identical methods: ImportFrom and
InsertFrom. The latter has a few lines of code more, so I've removed
InsertFrom (which was added to the code base later than ImportFrom),
added a boolean parameter to ImportFrom and adjusted the few calls to
those methods. And InsertFrom is not virtual like ImportFrom. Please
review the attached patches. I'll commit them if I get an "ok".
The changes affect three modules (libs-core/sfx2, writer/sw and
impress/sd).
When I took a quick look at it, I thought that it was about working with
Draw/Impress objects.
Is that correct?
If so, I could test the effect with some different scenarios.
I guess it will be resent in a nightly build soon?
Best regards,
Cor
--
- http://nl.libreoffice.org
- giving openoffice.org its foundation :: The Document Foundation -
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.