Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

Noel Power <nopower -AT- novell.com>
Wed, 01 Jun 2011 10:16:54 +0100

On 31/05/11 13:03, Chr. Rossmanith wrote:

Hi,

more duplicate code cleanup.
Class SfxObjectShell has two nearly identical methods: ImportFrom andInsertFrom. The latter has a few lines of code more, so I've removedInsertFrom (which was added to the code base later than ImportFrom),added a boolean parameter to ImportFrom and adjusted the few calls tothose methods. And InsertFrom is not virtual like ImportFrom. Pleasereview the attached patches. I'll commit them if I get an "ok".

looks good to me, please commit it to master ( or I will commit it laterafter I get a build /me unfortunately accidently did a make clean on hismaster build )


thanks
Noel

Context

[Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom · Chr. Rossmanith
- Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom · Noel Power
  - Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom · Christina Rossmanith
  - Re: [Libreoffice] [PATCH][PUSHED] Duplicate code: join ImportFrom and InsertFrom · Petr Mladek
- Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom · Cor Nouws

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.