Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

Cedric Bosdonnat <cedric.bosdonnat.ooo -AT- free.fr>
Mon, 23 May 2011 14:04:20 +0200

On Mon, 2011-05-23 at 04:21 -0600, Tor Lillqvist wrote:

On 2011-05-23 at 00:50, <markus.mohrhard@googlemail.com> wrote:

The problem here is that you are not allowed to access any element as long
as the ptr_vector is empty.

I think we should include this patch in 3-4-0.


Another crash introduced by a "Remove DECLARE_LIST" change, I am so not surprised.

+1 from me. Push this one-line patch first to master separately so that it can be cherry-picked, 
then do the more intrusive master-only rework. Thanks.


That one looks safe to me.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

Context

[Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Markus Mohrhard
- Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Tor Lillqvist
  - Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Markus Mohrhard
    - Re: [Libreoffice] [Review] [PUSHED] Patch for fdo#37429: crash when copy/paste table from writer to calc · Lubos Lunak
  - Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Cedric Bosdonnat
- Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.