Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Mon, 23 May 2011 13:52:39 +0200

2011/5/23 Tor Lillqvist <tlillqvist@novell.com>

On 2011-05-23 at 00:50, <markus.mohrhard@googlemail.com> wrote:

The problem here is that you are not allowed to access any element as

long

as the ptr_vector is empty.

I think we should include this patch in 3-4-0.


Another crash introduced by a "Remove DECLARE_LIST" change, I am so not
surprised.

+1 from me. Push this one-line patch first to master separately so that it
can be cherry-picked, then do the more intrusive master-only rework. Thanks.


Pushed to master.
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=d30c66cb1954103a159da2ef82dba4bf9685844f

Would be nice if we could get 2 additional reviews for 3-4-0.


--tml


_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context

[Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Markus Mohrhard
- Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Tor Lillqvist
  - Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Markus Mohrhard
    - Re: [Libreoffice] [Review] [PUSHED] Patch for fdo#37429: crash when copy/paste table from writer to calc · Lubos Lunak
  - Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Cedric Bosdonnat
- Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.